Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
graph-tool
graph-tool
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Tiago Peixoto
  • graph-toolgraph-tool
  • Merge Requests
  • !38

Merged
Opened Aug 27, 2020 by Alex Henrie@alex.henrieContributor

Simplifications identified with the help of Coverity

  • Overview 3
  • Commits 2
  • Pipelines 2
  • Changes 2

I ran graph-tool's source code through Coverity and it identified a couple of places where the code could be simplified.

Coverity also detected a possible bug on line 877 of graph_blockmodel_multiflip_mcmc.hh. The first argument to sample_split(size_t r, size_t s, RNG& rng) is r and the second is s, however r and s appear to be reversed when it is called with sample_split(s, r, rng). I didn't touch that code because I couldn't or tell whether or not this reversal was intentional, but I wanted to make you aware of it.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: count0/graph-tool!38
Source branch: coverity

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.