Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • graph-tool graph-tool
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Tiago Peixoto
  • graph-toolgraph-tool
  • Merge requests
  • !33

Use lambdas and pack expansion to reduce template instantiations in action_dispatch

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jeff Trull requested to merge jaafar/graph-tool:improved-action-dispatch into master Jul 10, 2020
  • Overview 11
  • Commits 1
  • Pipelines 4
  • Changes 2

This change produces significant reductions in compiler memory use (4.15GB to 2.81GB in my graph_assortativity testcase) and compiler runtime (180m to 168m overall, 206s to 188s in the testcase) by:

  1. Performing type iteration with parameter pack expansion where possible
  2. Testing the stored boost::any types sequentially instead of all at once (M+N instead of M*N operations)

I see no significant change in runtime with this approach, though it should in theory be an improvement.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improved-action-dispatch