From d6422b73bc33bfba976dff9db245d5069ec6e946 Mon Sep 17 00:00:00 2001
From: Tiago de Paula Peixoto <tiago@skewed.de>
Date: Sat, 31 Jan 2009 23:50:01 +0100
Subject: [PATCH] Fix symbol visibility

Now all symbols are exported by default, except those strictly marked
as hidden.
---
 configure.ac                 | 6 +++---
 src/graph/graph.hh           | 6 ------
 src/graph/graph_bind.cc      | 1 +
 src/graph/graph_filtering.hh | 3 ---
 src/graph/mpl_nested_loop.hh | 2 --
 5 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2d8fccb1..6f6a912d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -91,14 +91,14 @@ AC_ARG_ENABLE([optimization], [AC_HELP_STRING([--disable-optimization],
         [CXXFLAGS="${CXXFLAGS} -O99"]
         )
 
-AC_MSG_CHECKING(whether to enable hidden visibility...)
+AC_MSG_CHECKING(whether to enable symbol visibility manipulation...)
 
 AC_ARG_ENABLE([visibility], [AC_HELP_STRING([--disable-visibility],
-        [disable hidden visibility [default=enabled] ])],
+        [disable symbol visibility manipulation [default=enabled] ])],
         [AC_MSG_RESULT(no)]
         ,
         [AC_MSG_RESULT(yes)]
-        [CXXFLAGS="${CXXFLAGS} -fvisibility=hidden -fvisibility-inlines-hidden"]
+        [CXXFLAGS="${CXXFLAGS} -fvisibility=default -fvisibility-inlines-hidden"]
         )
 
 
diff --git a/src/graph/graph.hh b/src/graph/graph.hh
index 67cc5e91..4353fcba 100644
--- a/src/graph/graph.hh
+++ b/src/graph/graph.hh
@@ -51,9 +51,6 @@ template <class Action, class GraphViews,
 struct graph_action;
 }
 
-// default visibility is necessary for related typeinfo objects to work across
-// DSO boundaries
-#pragma GCC visibility push(default)
 class GraphInterface
 {
 public:
@@ -214,7 +211,6 @@ private:
     bool _edge_filter_invert;
     bool _edge_filter_active;
 };
-#pragma GCC visibility pop
 
 // Exceptions
 // ==========
@@ -222,7 +218,6 @@ private:
 // This is the main exception which will be thrown the outside world, when
 // things go wrong
 
-#pragma GCC visibility push(default)
 class GraphException : public std::exception
 {
     string _error;
@@ -233,7 +228,6 @@ public:
 protected:
     virtual void SetError(const string& error) {_error = error;}
 };
-#pragma GCC visibility pop
 
 } //namespace graph_tool
 
diff --git a/src/graph/graph_bind.cc b/src/graph/graph_bind.cc
index 6b55198f..f7347ea8 100644
--- a/src/graph/graph_bind.cc
+++ b/src/graph/graph_bind.cc
@@ -363,3 +363,4 @@ BOOST_PYTHON_MODULE(libgraph_tool_core)
         .add_property("install_prefix", &LibInfo::GetInstallPrefix)
         .add_property("python_dir", &LibInfo::GetPythonDir);
 }
+
diff --git a/src/graph/graph_filtering.hh b/src/graph/graph_filtering.hh
index 4d16674e..dd380c2c 100644
--- a/src/graph/graph_filtering.hh
+++ b/src/graph/graph_filtering.hh
@@ -106,7 +106,6 @@ using namespace boost;
 // appropriate graph view type and ValueType being 'double' and val = 42.0.
 
 // Whenever no implementation is called, the following exception is thrown
-#pragma GCC visibility push(default)
 class ActionNotFound: public GraphException
 {
 public:
@@ -119,7 +118,6 @@ private:
     const type_info& _action;
     vector<const type_info*> _args;
 };
-#pragma GCC visibility pop
 
 namespace detail
 {
@@ -496,7 +494,6 @@ BOOST_MPL_ASSERT_RELATION(n_views::value, == , mpl::int_<3>::value);
 
 // wrap action to be called, to deal with property maps, i.e., return version
 // with no bounds checking.
-
 template <class Action>
 struct action_wrap
 {
diff --git a/src/graph/mpl_nested_loop.hh b/src/graph/mpl_nested_loop.hh
index cf720bd6..482153cd 100644
--- a/src/graph/mpl_nested_loop.hh
+++ b/src/graph/mpl_nested_loop.hh
@@ -27,7 +27,6 @@ namespace boost
 {
 namespace mpl
 {
-
 // The following is a implementation of a nested for_each loop, which runs a
 // given Action functor for each combination of its arguments, given by the type
 // ranges, as such:
@@ -327,7 +326,6 @@ struct selected_types
     any _a1, _a2, _a3, _a4, _a5;
 };
 
-
 } // mpl namespace
 } // boost namespace
 
-- 
GitLab